Skip to content

Add laravel installer page #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add laravel installer page #281

wants to merge 1 commit into from

Conversation

teguh02
Copy link

@teguh02 teguh02 commented Aug 13, 2021

I add laravel installer page like a wordpress installer page to make it easier for everyone

@nasirkhan
Copy link
Owner

nasirkhan commented Aug 16, 2021

Thank you for submitting the pull request.

It would be a nice to have feature but I have a few opinion about this.

  1. To build the installer feature, you added rashidlaasri/LaravelInstaller package. I checked this package and the last release was more than a year ago. There are a number of open issues which is from from January 2019, last closed issue was on January 2021. So I think this is not an active project. What if the maintainer declare the project as archived?
  2. You can compare the Articles module with the Wordpress posts feature, but this is a started project and the target users are not large as Wordpress. You may build your application on top of this, which will save a big chunk of your time.
  3. The installer have a nice feature of checking the dependencies before installing. You can make a command to have this feature.
  4. One goal of this project is to be simple and be less dependent on other packages. So that it will not became a road block the main product.

In summary, I would like to use such packages which updates regularly. It is a starter project so it should have only the most useful features. Additional features can be added as separate modules. So I am sorry that I can not accept this pull request.

I am very happy that you are interested in improving this project. I would like to request you to check the list at #269, you may work on the features listed there or suggest something new as well.

@nasirkhan nasirkhan closed this Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants